added: CLI interface; added: search REPL #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added: search REPL
f-f
approved these changes
Jul 21, 2019
Member
f-f
left a comment
f-f
left a comment
There was a problem hiding this comment.
Nice work, looks great! 👏
I'd only suggest trying to split changes into self-contained PRs next time, to make review easier, as reviewing big PRs feels a bit intimidating. E.g. in this case we could have three different PRs: one for CLI interface, one for the search REPL, and one for adding npm publishing.
My personal rule of thumb is trying to keep PRs under +200 lines, with worst case of +500 lines (limits are independent from the language, as they are just about sheer size)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have an API.